p2p: migrate secret_connection from tmkms #696

melekes · 2020-11-20T12:52:30Z

NOTE: this is a copy of the secret_connection from tmkms with eyre errors and without generate_key function.

Referenced an issue explaining the need for the change
Updated all relevant documentation in docs
Updated all code comments where relevant
Wrote tests
Updated CHANGELOG.md

codecov-io · 2020-11-20T13:07:51Z

Codecov Report

Merging #696 (b689da8) into master (0fc7f40) will decrease coverage by 2.0%.
The diff coverage is 21.0%.

@@           Coverage Diff            @@
##           master    #696     +/-   ##
========================================
- Coverage    42.1%   40.1%   -2.1%     
========================================
  Files         191     200      +9     
  Lines       12597   12669     +72     
  Branches     3227    3182     -45     
========================================
- Hits         5312    5088    -224     
- Misses       6939    7258    +319     
+ Partials      346     323     -23

Impacted Files	Coverage Δ
p2p/src/error.rs	`0.0% <0.0%> (ø)`
p2p/src/secret_connection.rs	`0.0% <0.0%> (ø)`
p2p/src/secret_connection/amino_types.rs	`0.0% <0.0%> (ø)`
p2p/src/secret_connection/kdf.rs	`0.0% <0.0%> (ø)`
p2p/src/secret_connection/protocol.rs	`0.0% <0.0%> (ø)`
p2p/src/secret_connection/public_key.rs	`61.2% <61.2%> (ø)`
p2p/src/secret_connection/nonce.rs	`76.6% <76.6%> (ø)`
p2p/src/lib.rs	`100.0% <100.0%> (ø)`
light-client/src/store.rs	`52.0% <0.0%> (-20.0%)`	⬇️
rpc/src/request.rs	`25.0% <0.0%> (-17.9%)`	⬇️
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fc7f40...b689da8. Read the comment docs.

p2p/Cargo.toml

xla

Dope! Had a first pass mostly for the crate setup. Will look deeper into the code in a second pass.

p2p/Cargo.toml

p2p/src/lib.rs

p2p/Cargo.toml

p2p/src/secret_connection.rs

p2p/Cargo.toml

melekes · 2020-11-21T06:05:47Z

Thanks for the speedy feedback everyone 🚀

p2p/src/lib.rs

p2p/src/error.rs

p2p/src/secret_connection.rs

9e253df#r44484475

cargo-dep-bot · 2020-11-27T07:41:06Z

This PR made the following dependency changes:

Added Packages (Duplicate versions in '()'):
	aead 0.3.2
	chacha20 0.6.0
	chacha20poly1305 0.7.1
	cipher 0.2.5
	crypto-mac 0.10.0
	eyre 0.6.3
	hkdf 0.10.0
	hmac 0.10.1
	indenter 0.3.0
	keccak 0.1.0
	merlin 2.0.0
	poly1305 0.6.1
	tendermint-p2p 0.1.0
	universal-hash 0.4.0
	x25519-dalek 1.1.0

melekes · 2020-11-27T07:51:28Z

Made amino optional here.

xla

👛 🎣 ⛓ ✴️

p2p: migrate secret_connection from tmkms

06caa0d

Closes informalsystems#691

melekes added 3 commits November 20, 2020 17:27

bring back versions, remove generate_key

24b16ba

return proper error

5a2b5bf

format code

ee8190a

melekes marked this pull request as ready for review November 20, 2020 14:00

xla requested review from xla, romac and brapse and removed request for romac November 20, 2020 14:13

xla assigned melekes Nov 20, 2020

thanethomson reviewed Nov 20, 2020

View reviewed changes

p2p/Cargo.toml Outdated Show resolved Hide resolved

xla suggested changes Nov 20, 2020

View reviewed changes

p2p/Cargo.toml Outdated Show resolved Hide resolved

p2p/src/lib.rs Outdated Show resolved Hide resolved

p2p/src/lib.rs Outdated Show resolved Hide resolved

p2p/Cargo.toml Outdated Show resolved Hide resolved